Cue List faders problem

The issues found when using the Virtual Console
maximortal
Posts: 12
Joined: Mon Dec 19, 2016 7:07 pm
Real Name: Iro Suraci

Re: Cue List faders problem

Post by maximortal » Wed Jan 11, 2017 8:28 pm

I've testet GIT vers in real world (venue with 36 dimmers channels) so you can trust me, but this only if you lock faders.
IMHO can be useful if users can decide behaviours one as before and another like this one but working also with faders unlocked.

User avatar
mcallegari
Posts: 1602
Joined: Sun Apr 12, 2015 9:09 am
Location: Italy
Real Name: Massimo Callegari
Contact:

Re: Cue List faders problem

Post by mcallegari » Sat Jan 14, 2017 9:02 am

I have separated the blending into a dedicated check box (above the link check box), so now the logic is not implicit anymore in the linked faders case.
Also, the check boxes status is now saved into the project QXW file, so it is restored upon reloading.

Please check a test version and report if it works for you.

anorod
Posts: 14
Joined: Mon May 04, 2015 6:22 pm
Real Name: Antonio

Re: Cue List faders problem

Post by anorod » Sat Jan 14, 2017 10:19 am

Just checked the test version and seems perfect. It's a great idea to have an independent checkbox to control the behavior of the blending at anytime during the show.
Awesome work!

edogawa
Posts: 18
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

Re: Cue List faders problem

Post by edogawa » Sat Jan 14, 2017 7:23 pm

I agree (after another test with just the dmx monitor to control resulting values), this is an elegant solution and will work very well for me.

Thanks a lot, Massimo!

maximortal
Posts: 12
Joined: Mon Dec 19, 2016 7:07 pm
Real Name: Iro Suraci

Re: Cue List faders problem

Post by maximortal » Thu Jan 19, 2017 12:41 pm

tested 4.10.6.82 and it works fine
Nice job

edogawa
Posts: 18
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

Re: Cue List faders problem

Post by edogawa » Sat Jan 21, 2017 1:53 pm

There are two remaining cosmetic issues i still have and this might file under nit-picking, but i'm slightly annoyed everytime i come across them:

- the layout of the new checkbuttons: each is centered horizontally, and due to their different text lengths they don't line up in a vertical row. I played with the aignment settings and using "Qt::AlignLeft" instead of "Qt::AlignCenter" made them look pretty and in order. (vccuelist.cpp, lines 108 and 113)

- whenever one of the two sliders reaches the 100% position the geometry changes so that the sliders and main cuelist widget move a bit. I've read up Qt docs for hours now but I don't seem to be able to find how to set them to a static width that honours eventual font or fontsize changes etc. I suppose most of you devs have a good understanding of Qt and will be able to do this in no time, so I ask you kindly to do so :)

Thanks, Edgar

edogawa
Posts: 18
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

Re: Cue List faders problem

Post by edogawa » Tue Feb 14, 2017 8:21 am

Hello again,

I've forked and created a github pull request for a patch that deals with the first point in my previous post.

(

https://github.com/mcallegari/qlcplus/pull/941

I've only recently started to actively use git and github beyond merely cloning and pulling, so I hope I'm doing things correctly there.

Edgar

janosvitok
Posts: 684
Joined: Mon Apr 13, 2015 7:05 am
Location: Bratislava, Slovakia
Real Name: Jano Svitok
Contact:

Re: Cue List faders problem

Post by janosvitok » Tue Feb 14, 2017 3:00 pm

I've merged your PR. Thanks!

Jano

edogawa
Posts: 18
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

Re: Cue List faders problem

Post by edogawa » Wed Feb 15, 2017 3:12 pm

Hi Jano,

thank you too :)

And here's another PR, to address my second issue above: https://github.com/mcallegari/qlcplus/pull/944

I gave it another go, read a bit about QLayouts and started to grasp how it works, not very difficult in fact.

Cheers, Edgar

Post Reply