I've testet GIT vers in real world (venue with 36 dimmers channels) so you can trust me, but this only if you lock faders.
IMHO can be useful if users can decide behaviours one as before and another like this one but working also with faders unlocked.
Cue List faders problem
- mcallegari
- Posts: 4482
- Joined: Sun Apr 12, 2015 9:09 am
- Location: Italy
- Real Name: Massimo Callegari
- Contact:
I have separated the blending into a dedicated check box (above the link check box), so now the logic is not implicit anymore in the linked faders case.
Also, the check boxes status is now saved into the project QXW file, so it is restored upon reloading.
Please check a test version and report if it works for you.
Also, the check boxes status is now saved into the project QXW file, so it is restored upon reloading.
Please check a test version and report if it works for you.
-
- Posts: 64
- Joined: Mon Dec 19, 2016 7:07 pm
- Real Name: Iro Suraci
tested 4.10.6.82 and it works fine
Nice job
Nice job
- edogawa
- Posts: 572
- Joined: Thu May 07, 2015 10:34 am
- Real Name: Edgar Aichinger
There are two remaining cosmetic issues i still have and this might file under nit-picking, but i'm slightly annoyed everytime i come across them:
- the layout of the new checkbuttons: each is centered horizontally, and due to their different text lengths they don't line up in a vertical row. I played with the aignment settings and using "Qt::AlignLeft" instead of "Qt::AlignCenter" made them look pretty and in order. (vccuelist.cpp, lines 108 and 113)
- whenever one of the two sliders reaches the 100% position the geometry changes so that the sliders and main cuelist widget move a bit. I've read up Qt docs for hours now but I don't seem to be able to find how to set them to a static width that honours eventual font or fontsize changes etc. I suppose most of you devs have a good understanding of Qt and will be able to do this in no time, so I ask you kindly to do so
Thanks, Edgar
- the layout of the new checkbuttons: each is centered horizontally, and due to their different text lengths they don't line up in a vertical row. I played with the aignment settings and using "Qt::AlignLeft" instead of "Qt::AlignCenter" made them look pretty and in order. (vccuelist.cpp, lines 108 and 113)
- whenever one of the two sliders reaches the 100% position the geometry changes so that the sliders and main cuelist widget move a bit. I've read up Qt docs for hours now but I don't seem to be able to find how to set them to a static width that honours eventual font or fontsize changes etc. I suppose most of you devs have a good understanding of Qt and will be able to do this in no time, so I ask you kindly to do so
Thanks, Edgar
- edogawa
- Posts: 572
- Joined: Thu May 07, 2015 10:34 am
- Real Name: Edgar Aichinger
Hello again,
I've forked and created a github pull request for a patch that deals with the first point in my previous post.
(
https://github.com/mcallegari/qlcplus/pull/941
I've only recently started to actively use git and github beyond merely cloning and pulling, so I hope I'm doing things correctly there.
Edgar
I've forked and created a github pull request for a patch that deals with the first point in my previous post.
(
https://github.com/mcallegari/qlcplus/pull/941
I've only recently started to actively use git and github beyond merely cloning and pulling, so I hope I'm doing things correctly there.
Edgar
-
- Posts: 1274
- Joined: Mon Apr 13, 2015 7:05 am
- Location: Bratislava, Slovakia
- Real Name: Jano Svitok
- Contact:
I've merged your PR. Thanks!
Jano
Jano
- edogawa
- Posts: 572
- Joined: Thu May 07, 2015 10:34 am
- Real Name: Edgar Aichinger
Hi Jano,
thank you too
And here's another PR, to address my second issue above: https://github.com/mcallegari/qlcplus/pull/944
I gave it another go, read a bit about QLayouts and started to grasp how it works, not very difficult in fact.
Cheers, Edgar
thank you too
And here's another PR, to address my second issue above: https://github.com/mcallegari/qlcplus/pull/944
I gave it another go, read a bit about QLayouts and started to grasp how it works, not very difficult in fact.
Cheers, Edgar