4.11.0 Solo Frame Behavior

The issues found when using the Virtual Console
siegmund
Posts: 501
Joined: Mon Nov 02, 2015 11:03 am
Location: Germany
Real Name: Lukas

Re: 4.11.0 Solo Frame Behavior

Post by siegmund » Sat Jul 15, 2017 12:37 pm

I somehow like this idea. It will visually separate the two states and tells the user what is actually going on.
Just a quick first thought, that came to my mind: Maybe this could not be done with a frame, but rather with some highlighting of the font in the button?

User avatar
mcallegari
Posts: 1845
Joined: Sun Apr 12, 2015 9:09 am
Location: Italy
Real Name: Massimo Callegari
Contact:

Re: 4.11.0 Solo Frame Behavior

Post by mcallegari » Sat Jul 15, 2017 4:15 pm

I have prepared a prototype of the concept mentioned before.
Now buttons show a different visual feedback when they are running a function (green border) or when they are just monitoring a function (orange border)

Note that this doesn't include the 4.11.0 behavior, but it can be easily added. For now I just want to know if it could be a satisfactory solution for everyone.

Test builds with this change:
Windows: 4.11.1.51
macOS: QLC+_4.11.1-TEST-20170715.dmg (this build also reverts to Qt 5.6.2, so it should work on older macOS version too)
Linux: build the "tristate" branch from sources

maquelle
Posts: 7
Joined: Mon Apr 13, 2015 8:31 pm
Real Name:

Re: 4.11.0 Solo Frame Behavior

Post by maquelle » Sat Jul 15, 2017 9:24 pm

I quickly test this version and it's really great !

Thanks Massimo

volmar
Posts: 19
Joined: Sun Jan 03, 2016 4:34 pm
Real Name: Daniele

Re: 4.11.0 Solo Frame Behavior

Post by volmar » Sun Jul 16, 2017 10:58 am

mcallegari wrote:
Sat Jul 15, 2017 4:15 pm
I have prepared a prototype of the concept mentioned before.
Now buttons show a different visual feedback when they are running a function (green border) or when they are just monitoring a function (orange border)

Note that this doesn't include the 4.11.0 behavior, but it can be easily added. For now I just want to know if it could be a satisfactory solution for everyone.

Test builds with this change:
Windows: 4.11.1.51
macOS: QLC+_4.11.1-TEST-20170715.dmg (this build also reverts to Qt 5.6.2, so it should work on older macOS version too)
Linux: build the "tristate" branch from sources
I really think this is a great idea. Thanks for the effort regardless it makes to an official release or not.

siegmund
Posts: 501
Joined: Mon Nov 02, 2015 11:03 am
Location: Germany
Real Name: Lukas

Re: 4.11.0 Solo Frame Behavior

Post by siegmund » Sun Jul 16, 2017 12:11 pm

Just tested this and looks nice so far, thank you! I'm sure this will reduce confusion of the users. Before merging, there should still be some testing done. Because as we already discussed in the bug report thread, I think the "monitoring" buttons should not be affected by anything in the same frame, which is not the case at the moment.

Tubby
Posts: 16
Joined: Fri May 29, 2015 10:06 am
Real Name:

Re: 4.11.0 Solo Frame Behavior

Post by Tubby » Mon Jul 17, 2017 4:17 am

Hi Massimo,

Thanks for looking into this. As one of the users that exploited the bug... sorry.

For what it is worth, I do think the 4.11 Solo Frame is good, it enables a way of designing that wasn't possible before due to the bug. Also I think monitoring is a great idea, but I don't think that it will help here.

I think the useful bits of the bug can be reinstated and improved by:
1. Keeping the 4.11 Solo Behaviour.
2. Adding an option to Solo frames to "treat composite functions (see below) as a single function".
3. Add a new VC widget called a "Multi Press Button".
A "Multi Press Button" allows a user to press 1 or more VC buttons at the same time.
Unlike a collection, a "Multi Press Button" follows the VC programing, things like Solo Frames and Submasters. The "Multi Press Button" itself would not latch, but the buttons it presses would react as if the user activated them (don't toggle if already activated).

Expanding on Point 2:
As I see it there are two classes of functions in QLC+: Simple Functions and Composite Functions. I would define these types as below:
Simple Function:
A function that is fully defined and contained within itself.
These include: Scenes, Sequences, RGBMatrix, EFX

Composite Function:
A function that relies on one or more other functions for its definition.
These include: Chasers, Collections, Scripts, Shows (4.11 changes make this a moot point as they have their own private sequences)

As I wrote in earlier posts, I think that composite functions should be able to be treated as a single running function for the purposes of a Solo Frame.

siegmund
Posts: 501
Joined: Mon Nov 02, 2015 11:03 am
Location: Germany
Real Name: Lukas

Re: 4.11.0 Solo Frame Behavior

Post by siegmund » Mon Jul 17, 2017 10:35 am

Tubby wrote:
Mon Jul 17, 2017 4:17 am
2. Adding an option to Solo frames to "treat composite functions (see below) as a single function".
Let me first state, that I most probably explained the principle of composed functions wrong to you. Read this thread for a correct explanation by Massimo (so actually, composite functions are already treated as single functions, not as I explained as several functions). Anyway, adding such an option would require a huge change in QLC+ code so I'm sure this is out of the question.
Tubby wrote:
Mon Jul 17, 2017 4:17 am
3. Add a new VC widget called a "Multi Press Button".
You can already achieve that with the help of the loopback plugin.

gmint
Posts: 92
Joined: Wed Apr 15, 2015 8:04 pm
Real Name: George Qualley IV

Re: 4.11.0 Solo Frame Behavior

Post by gmint » Mon Jul 17, 2017 11:19 pm

mcallegari wrote:
Sat Jul 15, 2017 4:15 pm
I have prepared a prototype of the concept mentioned before.
Now buttons show a different visual feedback when they are running a function (green border) or when they are just monitoring a function (orange border)

Note that this doesn't include the 4.11.0 behavior, but it can be easily added. For now I just want to know if it could be a satisfactory solution for everyone.

Test builds with this change:
Windows: 4.11.1.51
macOS: QLC+_4.11.1-TEST-20170715.dmg (this build also reverts to Qt 5.6.2, so it should work on older macOS version too)
Linux: build the "tristate" branch from sources
Massimo, I like the test version. I want to say that when people started to discuss this, I KNEW someone was going to say, "can't we just have it both ways?" :mrgreen: I didn't want to be that guy. But I like what you've done!

User avatar
mcallegari
Posts: 1845
Joined: Sun Apr 12, 2015 9:09 am
Location: Italy
Real Name: Massimo Callegari
Contact:

Re: 4.11.0 Solo Frame Behavior

Post by mcallegari » Wed Jul 19, 2017 6:04 pm

So, 4.11.0 behavior is winning.
Basically the "monitoring" feature just brings some more clarity to who is controlling who.
Please help me testing version 4.11.1.57 (WIndows) and then I'll merge the change upstream and produce new test builds also for macOS.
Thanks

Post Reply