Bug in fixture validator

Here you can share your fixture definitions with the community
Post Reply
doughadfield
Posts: 29
Joined: Mon Nov 06, 2017 4:40 pm
Location: Herefordshire, UK
Real Name: Doug Hadfield

Bug in fixture validator

Post by doughadfield » Sat Nov 11, 2017 2:34 am

Hi wonderful people, I have a fixture definition which I wanted to post on this forum, so I've been trying to run it through the fixture validator. However, the strobe channel keeps generating an error. If I set the channel as "speed" the validator errors telling me it needs to be "Shutter". However if I set it to "shutter" it errors telling me it needs to be set to "speed". So whatever I do it won't validate. I attach the definition here. Can someone let me know whether I'm doing something wrong, or if it's the validator itself that's at fault.

thanks and regards

Doug
Attachments
Uking-LED-Par-36W-18LED.qxf
(2.42 KiB) Downloaded 2 times

edogawa
Posts: 26
Joined: Thu May 07, 2015 10:34 am
Real Name: Edgar Aichinger

Re: Bug in fixture validator

Post by edogawa » Sat Nov 11, 2017 3:48 pm

Hi Doug,

it seems that the validator makes that proposal based on keywords it finds in the channel name, and in this case gets confused by two contradicting keywords. I don't know whether the validator's source code is in github or otherwise available somewhere online, anyways I renamed it to just be "Strobe" and now it validates while being a shutter channel.

This sort of contradicts the guideline where you are supposed to stick with parameter naming from the devices' manual as close as possible... but maybe it is the best possible way to handle that, currently?

Ciao, Edgar

doughadfield
Posts: 29
Joined: Mon Nov 06, 2017 4:40 pm
Location: Herefordshire, UK
Real Name: Doug Hadfield

Re: Bug in fixture validator

Post by doughadfield » Mon Nov 13, 2017 11:49 am

Thanks a lot for your reply and your help, Edgar. I'll make the change this end, and bear your advice in mind :-)

Doug

User avatar
floEdelmann
Posts: 9
Joined: Tue Sep 20, 2016 4:47 pm
Real Name: Flo Edelmann

Re: Bug in fixture validator

Post by floEdelmann » Sat Nov 18, 2017 3:50 pm

The validator source code is available on GitHub, but buried deep in an issue's comment:

github.com/mcallegari/qlcplus/issues/963#issuecomment-297451371

Post Reply