Etiquette/Procedures for contributing?

Post Reply
mdmayfield
Posts: 69
Joined: Wed Jun 15, 2016 8:51 am
Real Name: Matt Mayfield

Etiquette/Procedures for contributing?

Post by mdmayfield » Sat Mar 04, 2017 4:13 pm

Hello everyone,

I'm putting together some large projects in QLC+ and am interested in contributing to development. However, I'm new to GitHub, and don't want to "step on anyone's toes" or commit a big faux pas so I'd like to ask:

- Should I bring up suggested changes here first, before opening any pull requests?
- When I find a fix for an issue, is it OK just propose/suggest the code in a pull request, or should I open an Issue first?
- Any other basic things a new contributor should be aware of (maybe a general FAQ elsewhere online)?

Thank you!

Matt

User avatar
mcallegari
Posts: 1933
Joined: Sun Apr 12, 2015 9:09 am
Location: Italy
Real Name: Massimo Callegari
Contact:

Re: Etiquette/Procedures for contributing?

Post by mcallegari » Sun Mar 05, 2017 9:35 am

Hi, I've just added a page to the GitHub wiki:
https://github.com/mcallegari/qlcplus/w ... guidelines

mdmayfield
Posts: 69
Joined: Wed Jun 15, 2016 8:51 am
Real Name: Matt Mayfield

Re: Etiquette/Procedures for contributing?

Post by mdmayfield » Sun Mar 05, 2017 9:32 pm

Thank you, I will review those before doing any more pull requests. Please pardon the mess on GitHub, I got a little too excited about making changes right away.

Post Reply